Fix CMake error in OS compiler workflow#2211
Conversation
|
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
|
Changes unknown |
ndgrigorian
force-pushed
the
fix-intel-sycl-compiler-cmake-os-ci
branch
3 times, most recently
from
b4097f7 to
4be2052
Compare
ndgrigorian
force-pushed
the
fix-intel-sycl-compiler-cmake-os-ci
branch
from
4be2052 to
bed074b
Compare
ndgrigorian
requested review from
antonwolfy and
vlad-perevezentsev
as code owners
|
Array API standard conformance tests for dpctl=0.22.0dev0=py310h93fe807_88 ran successfully. |
1 similar comment
|
Array API standard conformance tests for dpctl=0.22.0dev0=py310h93fe807_88 ran successfully. |
|
Array API standard conformance tests for dpctl=0.22.0dev0=py310h93fe807_88 ran successfully. |
antonwolfy
left a comment
antonwolfy
left a comment
There was a problem hiding this comment.
No more comments from me. LGTM!
now more robust, with an option for clang versioning (OS compiler) and DPC++ versioning
ndgrigorian
force-pushed
the
fix-intel-sycl-compiler-cmake-os-ci
branch
from
98d3194 to
3c380c9
Compare
|
@antonwolfy I've made a change to make this check more robust with regex, so each index is checked for either until a match is found, and that's used as the version. I added a commit to show the version, and as you can see, it matches what it was before. (last line in each screenshot) OS compiler: |
|
Array API standard conformance tests for dpctl=0.22.0dev0=py310h93fe807_93 ran successfully. |
|
Array API standard conformance tests for dpctl=0.22.0dev0=py310h93fe807_100 ran successfully. |
|
Array API standard conformance tests for dpctl=0.22.0dev0=py310h93fe807_99 ran successfully. |
antonwolfy
left a comment
antonwolfy
left a comment
There was a problem hiding this comment.
I have a minor nit below, but overall LGTM!
ndgrigorian
force-pushed
the
fix-intel-sycl-compiler-cmake-os-ci
branch
from
da6a73c to
04a9f04
Compare
|
Array API standard conformance tests for dpctl=0.22.0dev0=py310h93fe807_100 ran successfully. |
|
Array API standard conformance tests for dpctl=0.22.0dev0=py310h93fe807_101 ran successfully. |
|
Array API standard conformance tests for dpctl=0.22.0dev0=py310h93fe807_100 ran successfully. |
3 participants
This PR fixes the failing OS compiler workflow, which has been throwing a CMake error
OS compiler versioning output changed, so the Clang version is preceded by another string giving the date and specifying the compiler is the SYCL nightly compiler
This PR modifies dpctl CMake to check if the "Intel SYCL Compiler Nightly" string is in the version string. If so, the next member of the list, containing the Clang version, is used instead